On Mon, Oct 23, 2017 at 05:46:18PM +0000, Mario.Limonciello@xxxxxxxx wrote: > Mika, > > I'm not CC on patch 2/2 of this series (so apologies this probably won't come in threaded right), but I > was curious and reviewed it from the web: > http://www.spinics.net/lists/linux-doc/msg50034.html > > Are you sure this is true? When I saw this I tried it myself and didn't find the need for rescanning. > 1) I compiled thunderbolt.ko into the kernel. > 2) I compiled latest fwupd which contains both thunderbolt and thunderboltpower plugins. > 3) Ran /usr/lib/fwupd/fwupd -v > 4) Looked for thunderbolt and thunderboltpower related messages. > > I saw that: > 1) Thunderbolt Power was forced to 1 > 2) shortly later the thunderbolt uevent showed and device did enumerate in fwupd successfully. > 3) Thunderbolt power was set to 0 > 4) Thunderbolt remove event showed up soon (fwupd ignores the remove when forcepowered though). > > Is there something else needed to reproduce your behavior that prompted this doc change? > > If there is a situation like this, it makes sense for fwupd to also do the rescan, but I would like to be able > to reproduce it. You are right, there is no need to rescan (like I commented earlier to this patch). It is handled by whatever hotplug mechanism the system is using. PCs typically use BIOS assisted hotplug. I actually talked to Andy about this and he missed CONFIG_HOTPLUG_PCI_ACPI from his custom .config. -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
