Re: [PATCH] Documentation/sphinx: fix kernel-doc decode for non-utf-8 locale

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 31 Aug 2017 22:21:29 +0300
Jani Nikula <jani.nikula@xxxxxxxxx> wrote:

> On python3, Popen() universal_newlines=True converts the subprocess
> stdout to unicode text using a codec based on user preferences. Given
> LANG indicating ascii and utf-8 stdout from the subprocess, you'd get:
> 
> WARNING: kernel-doc '../scripts/kernel-doc -rst -enable-lineno
> ../drivers/media/dvb-core/demux.h' processing failed with: 'ascii' codec can't
> decode byte 0xe2 in position 6368: ordinal not in range(128)
> 
> Fix this by dropping universal_newlines=True and replacing the implicit
> LANG specific decode with an explicit utf-8 decode. This also gets rid
> of the annoying conditional code for python 2 vs. 3.
> 
> Fixes: ba3501859354 ("Documentation/sphinx: fix kernel-doc extension on python3")
> Reference: http://mid.mail-archive.com/54c23e8e-89c0-5cea-0dcc-e938952c5642@xxxxxxxxxxxxx
> Reported-and-tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Jonathan Corbet <corbet@xxxxxxx>
> Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx>
> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>

Cool...I go out to run some errands and the problem's fixed! :)

Patch applied, thanks to everybody for figuring this out.

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux