Em Thu, 10 Aug 2017 20:45:10 -0300 Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx> escreveu: > In the past, only string controls were pointers. That changed when compounded > types got added, but the compat32 code was not updated. > > We could just add those controls there, but maintaining it is flaw, as we > often forget about the compat code. So, instead, rely on the control type, > as this is always updated when new controls are added. > > As both v4l2-ctrl and compat32 code are at videodev.ko module, we can > move the ctrl_is_pointer() helper function to v4l2-ctrl.c. > > Mauro Carvalho Chehab (3): > media: v4l2-ctrls.h: better document the arguments for v4l2_ctrl_fill > media: v4l2-ctrls: prepare the function to be used by compat32 code > media: compat32: reimplement ctrl_is_pointer() > > drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 18 +--------- > drivers/media/v4l2-core/v4l2-ctrls.c | 49 +++++++++++++++++++++++++-- > include/media/v4l2-ctrls.h | 28 ++++++++++----- > 3 files changed, 67 insertions(+), 28 deletions(-) > Sorry, sent this series to the wrong mailing list. Will resend to the right one. Thanks, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
