On Tue, Jun 06, 2017 at 11:02:25AM -0700, Hoan Tran wrote: > This patch moves PMU leaf functions into a function pointer structure. > It helps code maintain and expasion easier. > > Signed-off-by: Hoan Tran <hotran@xxxxxxx> > --- > drivers/perf/xgene_pmu.c | 85 +++++++++++++++++++++++++++++++++++++----------- > 1 file changed, 66 insertions(+), 19 deletions(-) > -static inline u32 xgene_pmu_read_counter(struct xgene_pmu_dev *pmu_dev, int idx) > +static inline u64 xgene_pmu_read_counter32(struct xgene_pmu_dev *pmu_dev, > + int idx) > { > - return readl(pmu_dev->inf->csr + PMU_PMEVCNTR0 + (4 * idx)); > + return (u64)readl(pmu_dev->inf->csr + PMU_PMEVCNTR0 + (4 * idx)); > } Nit: the cast is redundant, and can go. Otherwise: Acked-by: Mark Rutland <mark.rutland@xxxxxxx> Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html