Re: [PATCHv2] docs: update references to the device io book

[SeongJae Park <sj38.park@xxxxxxxxx>]

On Fri, 28 Apr 2017, Helmut Grohne wrote:

> While converting deviceiobook.tmpl from DocBook to RST, dangling
> references were left behind. This commit updates all remaining
> references to the new location and fixes a typo "Documenataion".
> SeongJae Park improved the ko_KR translation.
>
> Fixes: 8a8a602fdb83 ("docs: Convert the deviceio template to RST")
> Signed-off-by: Helmut Grohne <h.grohne@xxxxxxxxxx>
> Signed-off-by: SeongJae Park <sj38.park@xxxxxxxxx>
> ---
> Documentation/memory-barriers.txt                    | 4 ++--
> Documentation/translations/ko_KR/memory-barriers.txt | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> I would like to thank Jonathan Corbet for spotting the fatal typo. This updated
> patch addresses all review remarks at the time of this writing:
> * Typo "Documenataion".
> * Added a more descriptive changelog.
> * Updated the ko_KR translation according to SeongJae Park's reply.
>
> I am left wondering whether Jonathan Corbet's review should incur a Reviewed-By
> tag and whether the other line from the ko_KR translation needs a similar
> update.
>
> Thanks for your time
>
> Helmut
>
> diff --git a/Documentation/memory-barriers.txt b/Documentation/memory-barriers.txt
> index d2b0a8d..d323adc 100644
> --- a/Documentation/memory-barriers.txt
> +++ b/Documentation/memory-barriers.txt
> @@ -2373,7 +2373,7 @@ is performed:
> 					spin_unlock(Q);
>
>
> -See Documentation/DocBook/deviceiobook.tmpl for more information.
> +See Documentation/driver-api/device-io.rst for more information.
>
>
> =================================
> @@ -2614,7 +2614,7 @@ might be needed:
>      relaxed memory access properties, then _mandatory_ memory barriers are
>      required to enforce ordering.
>
> -See Documentation/DocBook/deviceiobook.tmpl for more information.
> +See Documentation/driver-api/device-io.rst for more information.
>
>
> INTERRUPTS
> diff --git a/Documentation/translations/ko_KR/memory-barriers.txt b/Documentation/translations/ko_KR/memory-barriers.txt
> index ce0b48d..e5885ff 100644
> --- a/Documentation/translations/ko_KR/memory-barriers.txt
> +++ b/Documentation/translations/ko_KR/memory-barriers.txt
> @@ -2343,7 +2343,7 @@ ACQUIRE VS I/O 액세스
> 					spin_unlock(Q);
>
>
> -더 많은 정보를 위해선 Documenataion/DocBook/deviceiobook.tmpl 을 참고하세요.
> +더 많은 정보를 위해선 Documentation/driver-api/device-io.rst 를 참고하세요.

My opinion for postposition of the reference (s/을/를) has applied very 
well to above sentence.  However, it hasn't applied to the same sentence 
below.

> =========================
> @@ -2578,7 +2578,7 @@ CPU 에서는 사용되는 어토믹 인스트럭션 자체에 메모리 배리
>  (2) 만약 액세스 함수들이 완화된 메모리 액세스 속성을 갖는 I/O 메모리 윈도우를
>      사용한다면, 순서를 강제하기 위해선 _mandatory_ 메모리 배리어가 필요합니다.
>
> -더 많은 정보를 위해선 Documentation/DocBook/deviceiobook.tmpl 을 참고하십시오.
> +더 많은 정보를 위해선 Documentation/driver-api/device-io.rst 을 참고하십시오.

It would be better to modify the postposition of the reference as below:

 -더 많은 정보를 위해선 Documentation/DocBook/deviceiobook.tmpl 을 참고하십시오.
 +더 많은 정보를 위해선 Documentation/driver-api/device-io.rst 를 참고하십시오.


Thanks,
SeongJae Park

> 인터럽트
> --
> 2.1.4