Am 31.01.2017 um 08:36 schrieb Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>:
> On Tue, 31 Jan 2017, Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote:
>> As we use redirection to create the SVG file, even a failed conversion
>> will create the file and 'make' will consider it up-to-date if the
>> build is retried. We should delete it in case of failure.
>>
>> Fixes: ec868e4ee2bc ("docs-rst: media: build SVG from graphviz files")
>> Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
>> ---
>> Documentation/media/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/media/Makefile b/Documentation/media/Makefile
>> index 32663602ff25..730d73db7c7a 100644
>> --- a/Documentation/media/Makefile
>> +++ b/Documentation/media/Makefile
>> @@ -36,7 +36,7 @@ quiet_cmd_genpdf = GENPDF $2
>> cmd_genpdf = convert $2 $3
>>
>> quiet_cmd_gendot = DOT $2
>> - cmd_gendot = dot -Tsvg $2 > $3
>> + cmd_gendot = dot -Tsvg $2 > $3 || { rm -f $3; exit 1; }
>
> I'd just use dot -o.
I recommend / tested Jani's solution.
BTW, my 'convert' (ImageMagick) is very slow and CPU consuming:
GENPDF Documentation/media/uapi/v4l/selection.svg
takes approximately 20% - 30% of the **complete** build time
of the 'pdfdocs' target. Its only with 'selection.svg'. The
other conversions are fast.
Is this only to me?
Here is what I have installed ...
$ convert -version
Version: ImageMagick 6.8.9-9 Q16 x86_64 2016-11-29 http://www.imagemagick.org
Copyright: Copyright (C) 1999-2014 ImageMagick Studio LLC
Features: DPC Modules OpenMP
Delegates: bzlib cairo djvu fftw fontconfig freetype jbig jng jpeg lcms lqr ltdl lzma openexr pangocairo png rsvg tiff wmf x xml zlib
Thanks.
-- Markus --
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
