Re: [PATCH] Documentation/sphinx more portable version check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Em Mon, 19 Dec 2016 11:44:57 +0200
Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> escreveu:

> On Fri, 16 Dec 2016, Robert Bragg <robert@xxxxxxxxxxxxx> wrote:
> > The sphinx.__version__ string doesn't always include a patch version and
> > so the previous tuple decomposition failed with to few elements.
> >
> > Since I hit the case with no patch version ("1.5"), I guess it's
> > possible a major release might elide the minor version.
> >
> > Although there's an alternative sphinx.version_info tuple that looks
> > generally preferable to splitting the __version__ string, this opts to
> > continue using __version__ which existed prior to v 1.2.
> 
> IMO just go for sphinx.version_info for simplicity and per [1], and
> ignore Sphinx v1.1 and older. Even Debian stable has v1.2.

Agreed. I suspect that everything older than 1.2 won't work, anyway.

It could be interesting to print some error message if someone tries 
to build with an older version or if the version can't be detected,
asking the user to upgrade Sphinx.

Btw, I ended by installing a local instance on my Debian server with
a 1.4.x version, as it produces less warnings and produce a better
output. So, I don't test for a while if the current document builds
with 1.2.


Thanks,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux