Hi Guenter, On Nov 30, 2016, at 4:42 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > >> +Optional node properties: >> +- ti,thermostat-mode-comparator : (boolean) select the comparator mode for the >> + thermostat rather than the default interrupt-mode. >> + > I keep arguing with myself over this. Ultimately, I think it is not needed, > for a simple reason: As currently written, using the driver in anything but > comparator mode does not really make sense (because the alert status bits > will be reset after reading them in interrupt mode). Second, interrupt mode > can be determined automatically, based on the presence of SMBus alert support. > Given that, I wonder if it would make more sense to drop this property and > always put the chip into comparator mode for the time being. At a later time, > if and when alert support is added, we can discuss the best approach to > determine how it should be enabled (ie how do we know that the SMBus adapter > supports handling alerts, or would we assume that it always does ?). > > What do you think ? I did find myself putting the device into comparator mode in order to test the FL and FH bits, so I agree that it can be the default for now. When I can test the Alert pin, we can discuss adding interrupt and SMBus alert support. Once you have finished reviewing the other patch, I will make that change and re-send. Thanks, John. -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
