On Wed, 31 Aug 2016 17:29:30 +0200 Markus Heiser <markus.heiser@xxxxxxxxxxx> wrote: > + if major >= 1 and minor < 4: > + # indexnode's tuple changed in 1.4 > + # https://github.com/sphinx-doc/sphinx/commit/e6a5a3a92e938fcd75866b4227db9e0524d58f7c > + self.indexnode['entries'].append( > + ('single', indextext, targetname, '')) > + else: > + self.indexnode['entries'].append( > + ('single', indextext, targetname, '', None)) So this doesn't seem right. We'll get the four-entry tuple behavior with 1.3 and the five-entry behavior with 1.4...but what happens when 2.0 comes out? Did you want maybe: if major == 1 and minor < 4: ? (That will fail on 0.x, but we've already stated that we don't support below 1.2). jon -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
