On Mon, 15 Aug 2016 10:21:07 +0200 Markus Heiser <markus.heiser@xxxxxxxxxxx> wrote: > Jonathan, we had this already, I gave you the links to "python community > norms" and tools, please read/use them. > > * https://www.python.org/dev/peps/pep-0008/ > * https://www.pylint.org/ > > Some of these norms might be unusual for C developers. Markus, please. I'm pretty well familiar with the Python language, have read and written quite a bit of Python code, and understand the conventions. I don't need to be talked down to here. I just reviewed PEP8. Nothing I mentioned is sanctioned there; indeed, it says to limit lines to 79 characters and no space before commas. Please remember that, when you put code into the kernel, that code is no longer in your own personal sandbox. Other developers will have to look at and understand it, and the community will have to maintain it long after you have moved on to other things. We should do everything we can to make that code accessible to kernel folks, and that includes, IMO, not flying in the face of the kernel's coding conventions. Happily, normal Python conventions don't actually look all that strange to developers used to the kernel's style - at least to those who understand Python! There's no reason why we can't create Python code that looks fine to Python programmers without putting off kernel developers. It's not a matter of "eye candy," it's a real maintenance issue, so could you please humor me on this? Thanks, jon -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
