On Thu, Aug 11, 2016 at 11:15:13AM +0300, Jani Nikula wrote: > On Tue, 09 Aug 2016, Daniel Vetter <daniel.vetter@xxxxxxxx> wrote: > > These are the leftovers I could only track down using keep_warnings = > > True. For some of them we might want to update our style guide on how > > to reference structures and constants, not sure ... > > > > Cc: Markus Heiser <markus.heiser@xxxxxxxxxxx> > > Cc: Jonathan Corbet <corbet@xxxxxxx> > > Cc: linux-doc@xxxxxxxxxxxxxxx > > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx> > > --- > > drivers/gpu/drm/drm_crtc.c | 4 ++-- > > drivers/gpu/drm/drm_fb_helper.c | 2 +- > > drivers/gpu/drm/drm_irq.c | 8 +++---- > > drivers/gpu/drm/drm_simple_kms_helper.c | 2 +- > > drivers/gpu/drm/i915/i915_vgpu.c | 42 ++++++++++++++++----------------- > > drivers/gpu/drm/i915/intel_audio.c | 6 ++--- > > drivers/gpu/drm/i915/intel_guc_fwif.h | 5 ++-- > > include/drm/drm_crtc.h | 8 +++---- > > include/drm/drm_gem.h | 4 ++-- > > 9 files changed, 41 insertions(+), 40 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > > index 3d03eb1e3b63..ad38a8a31898 100644 > > --- a/drivers/gpu/drm/drm_crtc.c > > +++ b/drivers/gpu/drm/drm_crtc.c > > @@ -1272,7 +1272,7 @@ static unsigned int drm_num_planes(struct drm_device *dev) > > * @plane: plane object to init > > * @possible_crtcs: bitmask of possible CRTCs > > * @funcs: callbacks for the new plane > > - * @formats: array of supported formats (%DRM_FORMAT_*) > > + * @formats: array of supported formats (DRM_FORMAT\_\*) > > Future idea: If we turned DRM_FORMAT_* into an enum instead of a > plethora of macros, we could reference the enum here. Not to mention the > code being self-documenting too. DRM_FORMAT_* is uapi, so can't change it. -- Ville Syrjälä Intel OTC -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
