On Wed, 20 Jul 2016 12:38:58 +0200
Markus Heiser <markus.heiser@xxxxxxxxxxx> wrote:
> Add a reporter replacement that assigns the correct source name and line
> number to a system message, as recorded in a ViewList.
This is clearly a worthwhile fix, and I've applied it. A couple of little
notes, though...
> + self.state.memo.title_styles, self.state.memo.section_level = [], 0
Kernel coding style doesn't really extend to Python, but I believe this
sort of multiple assignment goes against its spirit. In the future, can we
just do it as two lines?
> - except Exception as e:
> + except Exception as e: # pylint: disable=W0703
> env.app.warn('kernel-doc \'%s\' processing failed with: %s' %
> (" ".join(cmd), str(e)))
> return [nodes.error(None, nodes.paragraph(text = "kernel-doc missing"))]
This hunk would appear to be an unrelated change?
Thanks,
jon
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
