[NAK] [PATCH v4 00/29] Fixed issues raised by tglx, then move visorbus to drivers/virt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: David Kershner [mailto:david.kershner@xxxxxxxxxx]
> Sent: Wednesday, June 8, 2016 5:14 PM
> To: corbet@xxxxxxx; tglx@xxxxxxxxxxxxx; mingo@xxxxxxxxxx;
> hpa@xxxxxxxxx; Kershner, David A <David.Kershner@xxxxxxxxxx>;
> gregkh@xxxxxxxxxxxxxxxxxxx; Arfvidson, Erik <Erik.Arfvidson@xxxxxxxxxx>;
> Sell, Timothy C <Timothy.Sell@xxxxxxxxxx>; hofrat@xxxxxxxxx;
> dzickus@xxxxxxxxxx; jes.sorensen@xxxxxxxxxx; Curtin, Alexander Paul
> <Alexander.Curtin@xxxxxxxxxx>; janani.rvchndrn@xxxxxxxxx;
> sudipm.mukherjee@xxxxxxxxx; prarit@xxxxxxxxxx; Binder, David Anthony
> <David.Binder@xxxxxxxxxx>; nhorman@xxxxxxxxxx;
> dan.j.williams@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> doc@xxxxxxxxxxxxxxx; driverdev-devel@xxxxxxxxxxxxxxxxxxxxxx; *S-Par-
> Maintainer <SParMaintainer@xxxxxxxxxx>
> Subject: [PATCH v4 00/29] Fixed issues raised by tglx, then move visorbus to
> drivers/virt
>

NAKed-by: David Kershner <david.kershner@xxxxxxxxxx>

We have decided that it would be cleaner if we separated this patchset
into 2 smaller patchsets:
 * patchset 1: fixes we need to make to the drivers in staging that
    are required before they are clean enough to move out of staging
 * patchset 2: patches that move code out of staging

Hence, we are retracting this patchset, and will soon submit 2 follow-on
patchsets that are split as-per the above bullets.


> tglx: The following patchset fixes issues you raised during your
> code review of visorbus on 5/18.
> 
> Converts visorbus to use a kernel timer for periodic device-specific
> callbacks instead of a workqueue, making the implementation in
> periodic_work.c and periodic_work.h no longer necessary.  These files
> are then deleted.
> 
> The visordriver_callback_lock has been switched to a mutex.
> 
> Several module parameters and structures were removed that were no
> longer being used.
> 
> Moves drivers/staging/unisys/include to include/linux/visorbus
> and moves drivers/staging/unisys/visorbus to drivers/virt/visorbus.
> 
> Changes since v3:
>  - Updated patches to apply cleanly on top of staging-next
>  - Modified patch comment to point to correct destination directory
> 
> Changes since v2:
>  - Fixed comments raised by Neil Horman regarding return -1 changes
>  - Fixed kernel-doc style comments for visorbus driver, and added
>    kernel-doc documentation for many more functions
>  - Reworked visorbus so we did not need notifier_lock
> 
> Changes since v1:
>  - Added the patch staging: unisys: visorbus change -1 return values
>  - Added the patch staging: unisys: visorchipset change -1 return value
>  - Added the patch staging: unisys: iovmcall_gnuc.h change -1 return values
> 
> Bryan Thompson (4):
>   staging: unisys: visorbus: Make visordriver_callback_lock a mutex
>   staging: unisys: visorbus: Remove unnecessary EXPORT_SYMBOL
> statements
>   staging: unisys: visorbus: Remove unused functions
>   staging: unisys: Remove reference to unused STANDALONE_CLIENT
> 
> David Binder (13):
>   staging: unisys: visorbus: remove unused module parameters
>   staging: unisys: visorbus: remove unused struct
>   staging: unisys: visorbus: modify format string to match argument
>   staging: unisys: visornic: Correct comment spelling mistake
>   staging: unisys: include: Remove thread-related enum members
>   staging: unisys: visorbus: fix commenting in vbusdevinfo.h
>   staging: unisys: visorbus: fix commenting in visorbus_main.c
>   staging: unisys: visorbus: fix visorchannel.c comments
>   staging: unisys: visorbus: Rectify commenting in visorchipset.c
>   staging: unisys: visorbus: Move visorbus-unique functions to private
>     header
>   staging: unisys: visorbus: rectify kerneldoc comment for struct
>   staging: unisys: visorbus: Remove notifier-related code from visorbus
>   staging: unisys: visorbus: Rename function to follow existing
>     convention
> 
> David Kershner (4):
>   staging: unisys: Move vbushelper.h to visorbus directory
>   include: linux: visorbus: Add visorbus to include/linux directory
>   Documentation: Move visorbus documentation from staging to
>     Documentation/
>   drivers: Add visorbus to the drivers/virt directory
> 
> Erik Arfvidson (2):
>   staging: unisys: visorbus: remove return values for write_vbus
>     functions
>   staging: unisys: visorbus: check parahotplug_request_complete_result
> 
> Tim Sell (6):
>   staging: unisys: visorbus: removed unused periodic_test_workqueue
>   staging: unisys: visorinput: remove unnecessary locking
>   staging: unisys: visorbus: use kernel timer instead of workqueue
>   staging: unisys: visorbus: remove periodic_work.h/.c
>   staging: unisys: visorbus: remove unused parameter from function
>   staging: unisys: visorbus: fix visorbus_private.h comments
> 
>  .../ABI/stable/sysfs-bus-visorbus                  |    0
>  .../overview.txt => Documentation/visorbus.txt     |    0
>  drivers/staging/unisys/Kconfig                     |    3 +-
>  drivers/staging/unisys/MAINTAINERS                 |    2 +-
>  drivers/staging/unisys/Makefile                    |    1 -
>  drivers/staging/unisys/include/periodic_work.h     |   40 -
>  drivers/staging/unisys/include/visorbus.h          |  234 ----
>  drivers/staging/unisys/visorbus/Makefile           |   12 -
>  drivers/staging/unisys/visorbus/periodic_work.c    |  204 ---
>  drivers/staging/unisys/visorbus/vbusdeviceinfo.h   |  213 ---
>  drivers/staging/unisys/visorbus/visorbus_main.c    | 1344 -------------------
>  drivers/staging/unisys/visorbus/visorbus_private.h |   68 -
>  drivers/staging/unisys/visorbus/visorchannel.c     |  635 ---------
>  drivers/staging/unisys/visorhba/Makefile           |    2 -
>  drivers/staging/unisys/visorhba/visorhba_main.c    |    5 +-
>  drivers/staging/unisys/visorinput/Makefile         |    2 -
>  drivers/staging/unisys/visorinput/visorinput.c     |   63 +-
>  drivers/staging/unisys/visornic/Makefile           |    2 -
>  drivers/staging/unisys/visornic/visornic_main.c    |    7 +-
>  drivers/virt/Kconfig                               |    2 +
>  drivers/virt/Makefile                              |    1 +
>  drivers/{staging/unisys => virt}/visorbus/Kconfig  |    0
>  drivers/virt/visorbus/Makefile                     |    9 +
>  .../unisys => virt}/visorbus/controlvmchannel.h    |    2 +-
>  .../visorbus/controlvmcompletionstatus.h           |    0
>  .../unisys => virt}/visorbus/iovmcall_gnuc.h       |    0
>  .../unisys => virt}/visorbus/vbuschannel.h         |    3 +-
>  drivers/virt/visorbus/vbusdeviceinfo.h             |  234 ++++
>  .../unisys/include => virt/visorbus}/vbushelper.h  |    0
>  drivers/virt/visorbus/visorbus_main.c              | 1403
> ++++++++++++++++++++
>  drivers/virt/visorbus/visorbus_private.h           |   65 +
>  drivers/virt/visorbus/visorchannel.c               |  516 +++++++
>  .../unisys => virt}/visorbus/visorchipset.c        |  442 +++---
>  .../unisys => virt}/visorbus/vmcallinterface.h     |    5 +-
>  .../include => include/linux/visorbus}/channel.h   |    0
>  .../linux/visorbus}/channel_guid.h                 |    0
>  .../linux/visorbus}/diagchannel.h                  |    0
>  .../linux/visorbus}/guestlinuxdebug.h              |    4 +-
>  .../include => include/linux/visorbus}/iochannel.h |    0
>  .../include => include/linux/visorbus}/version.h   |    0
>  include/linux/visorbus/visorbus.h                  |  200 +++
>  41 files changed, 2714 insertions(+), 3009 deletions(-)
>  rename drivers/staging/unisys/Documentation/ABI/sysfs-platform-
> visorchipset => Documentation/ABI/stable/sysfs-bus-visorbus (100%)
>  rename drivers/staging/unisys/Documentation/overview.txt =>
> Documentation/visorbus.txt (100%)
>  delete mode 100644 drivers/staging/unisys/include/periodic_work.h
>  delete mode 100644 drivers/staging/unisys/include/visorbus.h
>  delete mode 100644 drivers/staging/unisys/visorbus/Makefile
>  delete mode 100644 drivers/staging/unisys/visorbus/periodic_work.c
>  delete mode 100644 drivers/staging/unisys/visorbus/vbusdeviceinfo.h
>  delete mode 100644 drivers/staging/unisys/visorbus/visorbus_main.c
>  delete mode 100644 drivers/staging/unisys/visorbus/visorbus_private.h
>  delete mode 100644 drivers/staging/unisys/visorbus/visorchannel.c
>  rename drivers/{staging/unisys => virt}/visorbus/Kconfig (100%)
>  create mode 100644 drivers/virt/visorbus/Makefile
>  rename drivers/{staging/unisys => virt}/visorbus/controlvmchannel.h (99%)
>  rename drivers/{staging/unisys =>
> virt}/visorbus/controlvmcompletionstatus.h (100%)
>  rename drivers/{staging/unisys => virt}/visorbus/iovmcall_gnuc.h (100%)
>  rename drivers/{staging/unisys => virt}/visorbus/vbuschannel.h (99%)
>  create mode 100644 drivers/virt/visorbus/vbusdeviceinfo.h
>  rename drivers/{staging/unisys/include => virt/visorbus}/vbushelper.h
> (100%)
>  create mode 100644 drivers/virt/visorbus/visorbus_main.c
>  create mode 100644 drivers/virt/visorbus/visorbus_private.h
>  create mode 100644 drivers/virt/visorbus/visorchannel.c
>  rename drivers/{staging/unisys => virt}/visorbus/visorchipset.c (87%)
>  rename drivers/{staging/unisys => virt}/visorbus/vmcallinterface.h (98%)
>  rename {drivers/staging/unisys/include =>
> include/linux/visorbus}/channel.h (100%)
>  rename {drivers/staging/unisys/include =>
> include/linux/visorbus}/channel_guid.h (100%)
>  rename {drivers/staging/unisys/include =>
> include/linux/visorbus}/diagchannel.h (100%)
>  rename {drivers/staging/unisys/include =>
> include/linux/visorbus}/guestlinuxdebug.h (98%)
>  rename {drivers/staging/unisys/include =>
> include/linux/visorbus}/iochannel.h (100%)
>  rename {drivers/staging/unisys/include => include/linux/visorbus}/version.h
> (100%)
>  create mode 100644 include/linux/visorbus/visorbus.h
> 
> --
> 1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux