On 04/15/2016 03:01 PM, Jonathan Corbet wrote: > On Thu, 14 Apr 2016 11:08:11 +0200 > Geert Uytterhoeven <geert+renesas@xxxxxxxxx> wrote: > >> As mutex_lock() must not be called with interrupts disabled, >> .break_ctl() may sleep. > > So I've applied the first three to the docs tree, but this one stopped > me. The changelog doesn't really say why the patch is correct; what we > really need to know is that break_ctl() won't be called in atomic > context. The only caller of the uart driver's break_ctl() method is uart_break_ctl(), which is serial core's proxy tty driver break_ctl() method. uart_break_ctl() claims the struct tty_port::mutex to prevent concurrent tiocmset(). Thus, the uart driver's break_ctl() method won't be called in atomic context. Regards, Peter Hurley -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
