Use devm_mfd_add_devices() for mfd devices registration and remove the call of mfd_remove_devices() from .remove callback to remove mfd devices. This is done by managed device framework. Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx> CC: Chris Zhong <zyw@xxxxxxxxxxxxxx> --- drivers/mfd/rk808.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c index 4b1e439..a3026ca 100644 --- a/drivers/mfd/rk808.c +++ b/drivers/mfd/rk808.c @@ -213,7 +213,7 @@ static int rk808_probe(struct i2c_client *client, rk808->i2c = client; i2c_set_clientdata(client, rk808); - ret = mfd_add_devices(&client->dev, -1, + ret = devm_mfd_add_devices(&client->dev, -1, rk808s, ARRAY_SIZE(rk808s), NULL, 0, regmap_irq_get_domain(rk808->irq_data)); if (ret) { @@ -240,7 +240,6 @@ static int rk808_remove(struct i2c_client *client) struct rk808 *rk808 = i2c_get_clientdata(client); regmap_del_irq_chip(client->irq, rk808->irq_data); - mfd_remove_devices(&client->dev); pm_power_off = NULL; return 0; -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html