On Wed, Nov 25, 2015 at 09:46:37AM +0000, 河合英宏 / KAWAI,HIDEHIRO wrote: > Does *old* code mean the code without this patch *series* ? Yes. > I prefer this, but we might want to add some more prefix or suffix. > For example, "conditionally_run_crash_nmi_callback". That's unnecessary IMO. If you need to express that, you could write that in a comment above the function definition. Anyone who looks at the code then will know that it is conditional, like so many other kernel functions. :) > Thanks for your deep review! Thanks for the patience! :-) -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html