Hi Mauro,
Thank you for the patch.
On Sunday 06 September 2015 14:30:56 Mauro Carvalho Chehab wrote:
> Entities should have one or more functions. Calling it as a
> type proofed to not be correct, as an entity could eventually
s/proofed/proved/
> have more than one type.
>
> So, rename the field as function.
s/as/to/
> Please notice that this patch doesn't extend support for
> multiple function entities. Such change will happen when
> we have real case drivers using it.
>
> No functional changes.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx>
[snip]
> diff --git a/include/media/media-entity.h b/include/media/media-entity.h
> index 8bdc10dcc5e7..10f7d5f0eb66 100644
> --- a/include/media/media-entity.h
> +++ b/include/media/media-entity.h
> @@ -152,7 +152,8 @@ struct media_entity_operations {
> *
> * @graph_obj: Embedded structure containing the media object common data.
> * @name: Entity name.
> - * @type: Entity type, as defined at uapi/media.h (MEDIA_ENT_T_*)
> + * @function: Entity main function, as defined at uapi/media.h
> + * (MEDIA_ENT_F_*)
I would squash this patch with "uapi/media.h: Rename entities types to
functions" as they essentially touch the same lines. If you want to keep them
separate I would use MEDIA_ENT_T_* here and rename it to MEDIA_ENT_F_* in
"uapi/media.h: Rename entities types to functions".
> * @revision: Entity revision - OBSOLETE - should be removed soon.
> * @flags: Entity flags, as defined at uapi/media.h (MEDIA_ENT_FL_*)
> * @group_id: Entity group ID - OBSOLETE - should be removed soon.
[snip]
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
