On Wed, Aug 26, 2015 at 11:13:01AM +0530, Kamlakant Patel wrote: > On Wed, Aug 19, 2015 at 10:53:04AM -0700, Mark Brown wrote: > > On Wed, Aug 19, 2015 at 10:39:17AM +0530, kamlakant.patel@xxxxxxxxxxxx wrote: > > > +- clock-frequency : [OPTIONAL] Input clock frequency to the SPI block in Hz. > > > + Default is 133333333 Hz. > > I would expect this to be specifying the input clock to the block via > > the standard clock binding rather than just hard coding a number in > > here. This means the binding will continue to work for more complex > > sysetems with programmable clocks and is generally more standard. SoCs > > can still specify hard coded fixed frequency clocks as fixed clocks in > > the DT. > We don't have our clock framework upstream yet, and don't have > of_clk_init hook for Netlogic XLP platform to use fixed-clock. I will > update the driver and dts to use standard clock framework but for now we > will continue using "clock-frequency" and will update when clock framework > is upstream. No, you should leave it out - DT bindings are supposed to be permanent so we don't want to have temporary bindings that are expected to be removed quickly.
Attachment:
signature.asc
Description: Digital signature
