On 21.05.2015 11:32, fu.wei@xxxxxxxxxx wrote:
From: Fu Wei <fu.wei@xxxxxxxxxx>
Also update Documentation/watchdog/watchdog-kernel-api.txt to
introduce:
(1)the new elements in the watchdog_device and watchdog_ops struct;
(2)the new API "watchdog_init_timeouts".
Reasons:
(1)kernel already has two watchdog drivers are using "pretimeout":
drivers/char/ipmi/ipmi_watchdog.c
drivers/watchdog/kempld_wdt.c(but the definition is different)
(2)some other dirvers are going to use this: ARM SBSA Generic Watchdog
Hi,
As I was proposing some other API changes with my early-timeout-sec
work, I can see my work is going to collide with your API change
proposal a bit. So maybe I should ask your opinion as well..
Could this pretimeout feature be something that other drivers could
benefit too? I can see that it does not do anything else except call
panic() before letting the watchdog expire. This is something that could
be emulated easily by the watchdog core for drivers that don't know
anything about pretimeouts at all.
The way I was planning the API change there would need to be a small
change with each watchdog driver in order to let the watchdog core take
over generic behaviour on behalf of the driver. My goal was to make the
change so that each driver that gets converted to the new API extensions
gets a support for early-timeout-sec for free, without needing to enable
support for it any way. If the API was designed properly, also
pretimeouts could be handled easily and maybe even so that other drivers
could have that feature even though their hardware does not explicitly
give any support for it.
Any thoughts?
Thanks,
-Timo
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
