On Mon, Jan 12, 2015 at 03:09:55PM -0800, Sudeep Dutt wrote: > --- /dev/null > +++ b/include/uapi/linux/scif_ioctl.h > @@ -0,0 +1,213 @@ > +/* > + * Intel MIC Platform Software Stack (MPSS) > + * > + * This file is provided under a dual BSD/GPLv2 license. When using or > + * redistributing this file, you may do so under either license. > + * > + * GPL LICENSE SUMMARY > + * > + * Copyright(c) 2014 Intel Corporation. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of version 2 of the GNU General Public License as > + * published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, but > + * WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * General Public License for more details. > + * > + * BSD LICENSE > + * > + * Copyright(c) 2014 Intel Corporation. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions > + * are met: > + * > + * * Redistributions of source code must retain the above copyright > + * notice, this list of conditions and the following disclaimer. > + * * Redistributions in binary form must reproduce the above copyright > + * notice, this list of conditions and the following disclaimer in > + * the documentation and/or other materials provided with the > + * distribution. > + * * Neither the name of Intel Corporation nor the names of its > + * contributors may be used to endorse or promote products derived > + * from this software without specific prior written permission. > + * > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR > + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT > + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, > + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > + * > + * Intel SCIF driver. > + * > + */ > +/* > + * ----------------------------------------- > + * SCIF IOCTL interface information > + * ----------------------------------------- > + */ > +#ifndef SCIF_IOCTL_H > +#define SCIF_IOCTL_H > + > +/** > + * struct scif_port_id - SCIF port information > + * @node: node on which port resides > + * @port: local port number > + */ > +struct scif_port_id { > + uint16_t node; > + uint16_t port; variables that cross the kernel/user interface need to use the __* types, so these would be __u16. Please fix up all of these structures in this file. > +}; > + > +/** > + * struct scifioctl_connect - used for SCIF_CONNECT IOCTL > + * @self: used to read back the assigned port_id > + * @peer: destination node and port to connect to > + */ > +struct scifioctl_connect { > + struct scif_port_id self; > + struct scif_port_id peer; > +}; > + > +/** > + * struct scifioctl_accept - used for SCIF_ACCEPTREQ IOCTL > + * @flags: flags > + * @peer: global id of peer endpoint > + * @endpt: new connected endpoint descriptor > + */ > +struct scifioctl_accept { > + int flags; int? Please be specific of your types for ioctls. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html