Hi Boris, Boris Brezillon wrote: > Hi Sakari, > > On Fri, 14 Nov 2014 15:58:31 +0200 > Sakari Ailus <sakari.ailus@xxxxxx> wrote: > >> Hi Boris, >> >> On Fri, Nov 14, 2014 at 11:36:00AM +0100, Boris Brezillon wrote: ... >>> diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h >>> index 23b4090..cc7b79e 100644 >>> --- a/include/uapi/linux/media-bus-format.h >>> +++ b/include/uapi/linux/media-bus-format.h >>> @@ -33,7 +33,7 @@ >>> >>> #define MEDIA_BUS_FMT_FIXED 0x0001 >>> >>> -/* RGB - next is 0x100e */ >>> +/* RGB - next is 0x1010 */ >>> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001 >>> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002 >>> #define MEDIA_BUS_FMT_RGB555_2X8_PADHI_BE 0x1003 >>> @@ -47,6 +47,8 @@ >>> #define MEDIA_BUS_FMT_RGB888_2X12_BE 0x100b >>> #define MEDIA_BUS_FMT_RGB888_2X12_LE 0x100c >>> #define MEDIA_BUS_FMT_ARGB8888_1X32 0x100d >>> +#define MEDIA_BUS_FMT_RGB444_1X12 0x100e >>> +#define MEDIA_BUS_FMT_RGB565_1X16 0x100f >> >> I'd arrange these according to BPP and bits per sample, both in the header >> and documentation. > > I cannot keep both macro values and BPP/bits per sample in incrementing > order. Are you sure you prefer to order macros in BPP/bits per sample > order ? If you take a look elsewhere in the header, you'll notice that the ordering has preferred the BPP value (and other values with semantic significance) over the numeric value of the definition. I'd just prefer to keep it that way. This is also why the "next is" comments are there. -- Kind regards, Sakari Ailus sakari.ailus@xxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
