On Friday, November 14, 2014 03:35:44 AM Daniel Kurtz wrote:
> On Thu, Nov 13, 2014 at 6:01 AM, Caesar Wang <caesar.wang@xxxxxxxxxxxxxx> wrote:
> > +
> > + error = -ENXIO;
> > +
> > + for_each_available_child_of_node(np, node) {
> > + error = rockchip_pm_add_one_domain(pmu, node);
> > + if (error) {
> > + dev_err(dev, "failed to handle node %s: %d\n",
> > + node->name, error);
> > + goto err_out;
> > + }
> > + }
> > +
> > + if (error) {
> > + dev_dbg(dev, "no power domains defined\n");
>
> Perhaps dev_err() or dev_warn(), to ensure this message is seen.
> But, not have defined power domains doesn't seem like a fatal error.
> Perhaps just return 0?
As far as the driver concerned it is a fatal error - the driver can't do
anything when no domain is defined.
Thanks.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
