On Sat, Nov 01, 2014 at 01:45:47AM +0100, Rafael J. Wysocki wrote: > On Monday, October 20, 2014 11:04:46 AM Krzysztof Kozlowski wrote: > > @@ -198,8 +217,10 @@ static int amba_probe(struct device *dev) > > pm_runtime_enable(dev); > > > > ret = pcdrv->probe(pcdev, id); > > - if (ret == 0) > > + if (ret == 0) { > > + pcdev->irq_safe = pm_runtime_is_irq_safe(dev); > > This looks racy. > > Is it guaranteed that runtime PM callbacks won't be run for the device > after pcdrv->probe() has returned and before setting pcdev->irq_safe? > If not, inconsistent behavior may ensue. You are absolutely correct. So that knocks that idea on its head. -- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html