On Fri, Jul 18, 2014 at 6:50 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Friday 18 July 2014 14:59:45 Chanwoo Choi wrote:
>> Must be "samsung,exynos-adc-v2" for
>> future controllers.
>
> It would be good to change 'future controllers' to something else now.
> Presumably that word was used before the actual products were announced,
> but now they are publically known.
>
>> + Must be "samsung,exynos3250-adc-v2" for
>> + controllers compatible with ADC of Exynos3250.
>
> Doesn't this version have a specific name as well? The ADC block
> seems to use version numbers, so better put those in here to avoid
> confusion when another Exynos7890 comes out that uses the same
> ADC as exynos3250.
If don't add new compatible including specific exynos version,
I would add new 'adc-needs-sclk' property with existing 'exynos-adc-v2'
compatible name.
Dear Naveen, Tomasz,
If existing exynos-adc driver add just one property for 'sclk_adc'
as following, exynos-adc could not include the exynos version
in compatible name.
I need your opinion about it.
adc: adc@126C0000 {
compatible = "samsung,exynos-adc-v2";
reg = <0x126C0000 0x100>, <0x10020718 0x4>;
interrupts = <0 137 0>;
clock-names = "adc", "sclk_adc";
clocks = <&cmu CLK_TSADC>, <&cmu CLK_SCLK_TSADC>;
+ adc-needs-sclk;
#io-channel-cells = <1>;
io-channel-ranges;
}
Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
