On Tue, Jul 15, 2014 at 5:27 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Tuesday 15 July 2014 16:45:39 Ley Foon Tan wrote: >> +#ifndef _ASM_NIOS2_IRQ_H >> +#define _ASM_NIOS2_IRQ_H >> + >> +#define NIOS2_CPU_NR_IRQS 32 >> +/* Reserve 32 additional interrupts for GPIO IRQs */ >> +#define NR_IRQS (NIOS2_CPU_NR_IRQS + 32) > > Is this intentional? I would expect that you use SPARSE_IRQ > instead and not define NR_IRQS. Okay, will change to use SPARSE_IRQ. > >> +#ifndef NO_IRQ >> +#define NO_IRQ (-1) >> +#endif > > New architectures should no longer define NO_IRQ. Please fix all users > you encounter instead. Okay. > >> diff --git a/arch/nios2/kernel/irq.c b/arch/nios2/kernel/irq.c >> new file mode 100644 >> index 0000000..8770d50 >> --- /dev/null >> +++ b/arch/nios2/kernel/irq.c >> +#include <linux/init.h> >> +#include <linux/interrupt.h> >> +#include <linux/of.h> > > Maybe move this into drivers/irqchip/? Probably doesn't matter either way, > your choice. Will keep it here. BTW, this interrupt controller is part of Nios2 cpu architecture. Should we move to drivers/irqchip/ if that's the case? Any example of arch doing this? Thanks. Regards Ley Foon -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
