Hi Harini, On Thu, Jul 10, 2014 at 10:50 AM, Harini Katakam <harinik@xxxxxxxxxx> wrote: > + master->flags = SPI_MASTER_QUAD_MODE; SPI_MASTER_QUAD_MODE is not one of the SPI_MASTER_* defines in include/linux/spi/spi.h? > + master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_RX_DUAL | SPI_RX_QUAD | > + SPI_TX_DUAL | SPI_TX_QUAD; Your driver advertises Dual/Quad SPI Transfer capabilities, but it doesn't check spi_transfer.[tr]x_nbits? How can it determine when to enable Dual/Quad? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html