On Mon, 07 Jul 2014, Kishon Vijay Abraham I wrote: > Hi, > > On Monday 07 July 2014 06:42 PM, Lee Jones wrote: > > On Fri, 04 Jul 2014, Kishon Vijay Abraham I wrote: > > > >> In case of multi-phy PHY providers, each PHY should be modeled as a sub > >> node of the PHY provider. Then each PHY will have a different node pointer > >> (node pointer of sub node) than that of PHY provider. Added this provision > >> in the PHY core. > >> Also fixed all drivers to use the updated API. > >> > >> Signed-off-by: Kishon Vijay Abraham I <kishon@xxxxxx> > >> --- > >> Documentation/phy.txt | 10 ++++++---- > >> drivers/phy/phy-bcm-kona-usb2.c | 2 +- > >> drivers/phy/phy-core.c | 25 ++++++++++++++++++------- > >> drivers/phy/phy-exynos-dp-video.c | 2 +- > >> drivers/phy/phy-exynos-mipi-video.c | 2 +- > >> drivers/phy/phy-exynos5-usbdrd.c | 3 ++- > >> drivers/phy/phy-exynos5250-sata.c | 2 +- > >> drivers/phy/phy-mvebu-sata.c | 2 +- > >> drivers/phy/phy-omap-usb2.c | 2 +- > >> drivers/phy/phy-samsung-usb2.c | 3 ++- > >> drivers/phy/phy-sun4i-usb.c | 2 +- > >> drivers/phy/phy-ti-pipe3.c | 2 +- > >> drivers/phy/phy-twl4030-usb.c | 2 +- > >> drivers/phy/phy-xgene.c | 2 +- > >> include/linux/phy/phy.h | 15 ++++++++++----- > >> 15 files changed, 48 insertions(+), 28 deletions(-) > > > > I wrote a very similar patch already. I knew I should have sent it on > > Friday. :( > > No problem! you can send your patch along with the MiPHY series. That's okay. It's silly for us both to submit the same patch and yours hit the MLs first & looks good so, the honour is yours. > > Patch looks good, just a real minor point. > > > >> phy->dev.class = phy_class; > >> phy->dev.parent = dev; > >> - phy->dev.of_node = dev->of_node; > >> + phy->dev.of_node = node?node:dev->of_node; > > > > There should be spaces either side of the '?' and ':', or you can do > > this more succinctly by: > > > > phy->dev.of_node = node ?: dev->of_node; > > > > Once fixed, feel free to add my: > > > > Acked-by: Lee Jones <lee.jones@xxxxxxxxxx> > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
