On 06/13/2014 05:39 PM, Rafael J. Wysocki wrote: > > -#define RESTORE_MAGIC 0x0123456789ABCDEFUL > +#define RESTORE_MAGIC 0x0123456789ABCDF0UL > <bikeshed> Please don't pick numbers like this for magic numbers... *everyone else does, too.* In general, picking a random number is a good starting point; for extra bonus make sure it has at least one invalid UTF-8 sequence in it (so it cannot be confused with either ASCII or UTF-8 text.) </bikeshed> -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
