On Wed, Jun 4, 2014 at 2:25 PM, Rickard Strandqvist
<rickard_strandqvist@xxxxxxxxxxxxxxxxxx> wrote:
> Added a guaranteed null-terminate after call to strncpy.
>
> This was partly found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx>
> ---
> Documentation/accounting/getdelays.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/accounting/getdelays.c b/Documentation/accounting/getdelays.c
> index c6a06b7..f405780 100644
> --- a/Documentation/accounting/getdelays.c
> +++ b/Documentation/accounting/getdelays.c
> @@ -314,6 +314,7 @@ int main(int argc, char *argv[])
> break;
> case 'm':
> strncpy(cpumask, optarg, sizeof(cpumask));
> + cpumask[sizeof(cpumask) - 1] = '\0';
> maskset = 1;
> printf("cpumask %s maskset %d\n", cpumask, maskset);
> break;
> --
> 1.7.10.4
>
Yup, looks right. Thanks for the patch! Luckily this is just example code. :)
Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>
-Kees
--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
