On Thu, May 15, 2014 at 8:03 PM, Boris BREZILLON <boris.brezillon@xxxxxxxxxxxxxxxxxx> wrote: > Hello Carlo, > > On 11/04/2014 11:38, Carlo Caione wrote: >> AXP202 and AXP209 come with two synchronous step-down DC-DCs and five >> LDOs. This patch introduces basic support for those regulators. >> >> Signed-off-by: Carlo Caione <carlo@xxxxxxxxxx> >> --- >> drivers/regulator/Kconfig | 7 + >> drivers/regulator/Makefile | 1 + > [...] >> + if (!np) >> + return 0; >> + >> + regulators = of_find_node_by_name(np, "regulators"); > > I know I'm late, and this patch has already been applied, but shouldn't > we use of_get_child_by_name instead of of_find_node_by_name. > This might lead to wrong regulators node parsing if other regulators are > defined in the DT after the axp20x node, because, AFAIK, this function > searches for DT nodes defined after the specified np node, but not > necessarely children of the np node. Right. I'll prepare a fix. Feel free to submit a patch if you want. Thank you, -- Carlo Caione -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
