> >> +static struct platform_driver sun6i_prcm_driver = { > >> + .driver = { > >> + .name = "sun6i-prcm", > >> + .owner = THIS_MODULE, > >> + .of_match_table = sun6i_prcm_dt_ids, > >> + }, > >> + .probe = sun6i_prcm_probe, > > You need a .remove() call-back. > > This driver cannot be compiled as module (see the Kconfig definition) > and the devices are not hotpluggable, as a result a probed device will > never be removed. > > Do you still want me to implement the remove function ? .remove() also be run on shut down. It's best practice to have one. > >> +module_platform_driver(sun6i_prcm_driver); > >> + > >> +MODULE_AUTHOR("Boris BREZILLON <boris.brezillon@xxxxxxxxxxxxxxxxxx>"); > >> +MODULE_DESCRIPTION("Allwinner sun6i PRCM driver"); > >> +MODULE_LICENSE("GPL v2"); > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html