On Mon, Mar 17, 2014 at 05:30:17PM +0000, Mark Brown wrote: > On Mon, Mar 17, 2014 at 05:35:36PM +0530, Harini Katakam wrote: [..] > > +static int __maybe_unused cdns_spi_suspend(struct device *dev) > > +{ > > This needs to call spi_master_suspend() as well (and similarly on > resume). I'm not that familiar with the SPI core, but this seems like an inversion. Is there a reason why the SPI master class doesn't implement suspend/resume() callbacks which handle stopping/starting the queue automatically for all masters? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html