Re: [RFC v6,2/3] controls.xml : add addtional Flash fault bits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Daniel,

Thanks for the update. Just one comment below.

On Wed, Feb 26, 2014 at 04:04:10PM +0900, Daniel Jeong wrote:
> Descriptions for flash faluts.
>  V4L2_FLASH_FAULT_UNDER_VOLTAGE,
>  V4L2_FLASH_FAULT_INPUT_VOLTAGE,
>  and V4L2_FLASH_FAULT_LED_OVER_TEMPERATURE
> 
> Signed-off-by: Daniel Jeong <gshark.jeong@xxxxxxxxx>
> ---
>  Documentation/DocBook/media/v4l/controls.xml |   18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/Documentation/DocBook/media/v4l/controls.xml b/Documentation/DocBook/media/v4l/controls.xml
> index a5a3188..16f8af3 100644
> --- a/Documentation/DocBook/media/v4l/controls.xml
> +++ b/Documentation/DocBook/media/v4l/controls.xml
> @@ -4370,6 +4370,24 @@ interface and may change in the future.</para>
>      		  <entry>The flash controller has detected a short or open
>      		  circuit condition on the indicator LED.</entry>
>      		</row>
> +    		<row>
> +    		  <entry><constant>V4L2_FLASH_FAULT_UNDER_VOLTAGE</constant></entry>
> +    		  <entry>Flash controller voltage to the flash LED
> +    		  has been below the minimum limit specific to the flash
> +    		  controller.</entry>
> +    		</row>
> +    		<row>
> +    		  <entry><constant>V4L2_FLASH_FAULT_INPUT_VOLTAGE</constant></entry>
> +    		  <entry>The flash current can't reach to the target current
> +    		  because the input voltage is dropped below lower limit. 
> +    		  and Flash controller have adjusted the flash current
> +    		  not to occur under voltage event.</entry>

How about this:

"The input voltage of the flash controller is below the limit under which
strobing the flash at full current will not be possible. The condition
persists until this flag is no longer set."

> +    		</row>
> +    		<row>
> +    		  <entry><constant>V4L2_FLASH_FAULT_LED_OVER_TEMPERATURE</constant></entry>
> +    		  <entry>The temperature of the LED has exceeded its
> +    		  allowed upper limit.</entry>
> +    		</row>
>      	      </tbody>
>      	    </entrytbl>
>      	  </row>

-- 
Kind regards,

Sakari Ailus
e-mail: sakari.ailus@xxxxxx	XMPP: sailus@xxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux