On Tue, Feb 25, 2014 at 12:06:49AM +0800, Nicolin Chen wrote: > On Mon, Feb 24, 2014 at 03:52:24PM +0000, Austin, Brian wrote: > Wait...Regarding this clock part, I just forgot the reason I put the code: > 385 cs42888->clk = devm_clk_get(&i2c->dev, "mclk"); > 386 if (IS_ERR(cs42888->clk)) > 387 dev_warn(&i2c->dev, "failed to get the clock: %ld\n", > 388 PTR_ERR(cs42888->clk)); > was because the MCLK might be provided from SoC (DAI master) so it could > be totally controlled by CPU DAI driver, ESAI for example has its own > dividers to derive the HCKT clock (MCLK for Tx) from ahb clock in SoC > clock tree, in which case we might not easily pass a valid clock phandle > via DT. (RFC to this thought.) We should be getting those clocks visible in the clock API rather than doing this.
Attachment:
signature.asc
Description: Digital signature
