On Wed, Feb 12, 2014 at 01:43:37PM -0800, Andrew Chew wrote: > > > +static void tegra_wdt_unref(struct watchdog_device *wdd) { > > > + struct tegra_wdt *wdt = watchdog_get_drvdata(wdd); > > > + > > > + kref_put(&wdt->kref, tegra_wdt_release_resources); } > > > > I forget why these were needed; they seem to do nothing. > > The reason I did the whole kref thing was by following the guidance > in Documentation/watchdog/watchdog-kernel-api.txt, which says > that if the watchdog_device struct is dynamically allocated, then > one needs this. > I read that too, but I could not follow the logic behind it, nor the explanation provided with the commit introducing it ;-) Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html