On 02/03/2014 05:17 PM, Andrew Chew wrote:
> Add a driver for the hardware watchdogs in NVIDIA Tegra SoCs (tegra30 and
s/tegra30/Tegra30/
> later). This driver will configure one watchdog timer that will reset the
> system in the case of a watchdog timeout.
>
> This driver binds to the nvidia,tegra30-timer device node and gets its
> register base from there.
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> +config TEGRA_WATCHDOG
> + tristate "Tegra watchdog"
> + depends on ARCH_TEGRA
|| COMPILE_TEST ?
> diff --git a/drivers/watchdog/tegra_wdt.c b/drivers/watchdog/tegra_wdt.c
> +static int tegra_wdt_probe(struct platform_device *pdev)
> + /* This is the timer base. */
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + if (!res) {
...
> + mem = devm_request_mem_region(&pdev->dev, res->start,
> + resource_size(res),
> + pdev->name);
> + if (!mem) {
...
> + regs = devm_ioremap(&pdev->dev, mem->start,
> + resource_size(mem));
> + if (!regs) {
...
I forget exactly which of those, but I think at least one/some of those
don't need to be error-checked, since the later functions will detect an
error input, and return an appropriate error code, so they can be
chained together while only error-checking the final result.
> +static int tegra_wdt_remove(struct platform_device *pdev)
> + platform_set_drvdata(pdev, NULL);
There's no need to do that; the value of drvdata is irrelevant when the
device isn't probed, so there's no need for it to be NULL.
> +static struct platform_driver tegra_wdt_driver = {
> + .probe = tegra_wdt_probe,
> + .remove = tegra_wdt_remove,
> +#ifdef CONFIG_PM
> + .suspend = tegra_wdt_suspend,
> + .resume = tegra_wdt_resume,
> +#endif
I think for suspend/resume, you'd usually set it up like:
static const struct dev_pm_ops tegra20_i2s_pm_ops = {
SET_RUNTIME_PM_OPS(tegra20_i2s_runtime_suspend,
tegra20_i2s_runtime_resume, NULL)
};
static struct platform_driver tegra20_i2s_driver = {
.driver = {
...
.pm = &tegra20_i2s_pm_ops,
},
...
};
> + .driver = {
> + .owner = THIS_MODULE,
> + .name = "tegra-wdt",
> + .of_match_table = tegra_wdt_of_match,
> + },
> +};
> +
> +module_platform_driver(tegra_wdt_driver);
No need for the blank line before module_platform_driver().
> +MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR);
> +MODULE_ALIAS("platform:tegra-wdt");
You don't need at least that second alias; everything binds to the
MODULE_DEVICE_TABLE() now with DT.
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
