Hi Suzuki, On Mon, Mar 10, 2025 at 10:57:25AM +0000, Suzuki Kuruppassery Poulose wrote: > Hi Leo > > On 10/03/2025 10:49, Leo Yan wrote: > > The trace unit is controlled in the ETM hardware enabling and disabling. > > The sequential changes for support AUX pause and resume will reuse the > > same operations. > > > > Extract the operations in the etm4_{enable|disable}_trace_unit() > > functions. A minor improvement in etm4_enable_trace_unit() is for > > returning the timeout error to callers. > > > > Signed-off-by: Leo Yan <leo.yan@xxxxxxx> > > fyi, this area of code has changes significantly and will cause > conflicts, due to the introduction of synchronization after > each access to the TRCSTATR. Please rebase your next version on > the coresight next branch to avoid the conflict. Sure. Will rebase on CoreSight next branch [1]. Thanks for reminding. Leo [1] https://web.git.kernel.org/pub/scm/linux/kernel/git/coresight/linux.git/log/?//h=next > The changes as such look good to me. > > Suzuki