On Fri, Jan 3, 2014 at 9:40 PM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote: > Hi, > > On Mon, Nov 11, 2013 at 04:50:20PM +0530, Yuvaraj Kumar C D wrote: >> From: Vasanth Ananthan <vasanthananthan@xxxxxxxxx> >> >> This patch adds polling mode support for i2c-s3c2410 driver.The >> SATA PHY controller's CMU and TRSV block's are of I2C register >> map in exynos5250.These blocks can be configured using i2c. >> >> But i2c controller instance on which these block's sits lacks an >> interrupt line.Also the current i2c-s3c2410 driver is only interrupt >> driven, thus a polling mode support is required in the driver for >> supporting this controller. This patch adds this support to the driver. >> >> Changes from V1: >> 1.Changed the is_ack() to have even period b/w polls and >> used usleep_range() instead of udelay(). > > Mileages vary, but I'd like to see revision changes after the "---". > >> ret = devm_request_irq(&pdev->dev, i2c->irq, s3c24xx_i2c_irq, 0, >> - dev_name(&pdev->dev), i2c); >> + dev_name(&pdev->dev), i2c); > > Unrelated change. > > Rest looks good, so I'll fix up the things for you and apply to > for-next, thanks! Thanks Wolfram. > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
