From: Jakub Kicinski <kuba@xxxxxxxxxx> Date: Thu, 6 Mar 2025 10:05:33 -0800 > We haven't had much discussion on the list about this, but > a handful of people have been confused about rules on > posting selftests for fixes, lately. I tend to post fixes > with their respective selftests in the same series. > There are tradeoffs around size of the net tree and conflicts > but so far it hasn't been a major issue. > > Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx> > --- > Documentation/process/maintainer-netdev.rst | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/process/maintainer-netdev.rst b/Documentation/process/maintainer-netdev.rst > index e497729525d5..1ac62dc3a66f 100644 > --- a/Documentation/process/maintainer-netdev.rst > +++ b/Documentation/process/maintainer-netdev.rst > @@ -311,6 +311,14 @@ user space patches should form separate series (threads) when posted > Posting as one thread is discouraged because it confuses patchwork > (as of patchwork 2.2.2). > > +Co-posting selftests > +-------------------- > + > +Selftests should be part of the same series as the code changes. > +Specifically for fixes both code change and related test should go into > +the same tree (the tests may lack a Fixes tag, which is expected). > +Mixing code changes and test changes in a single commit is discouraged. I guess an exception for the mixing is when a code change breaks a selftest, or is it fine for NIPA ? (still other CI may complain though)
