Re: [PATCH net-next v2 2/8] netconsole: Make boolean comparison consistent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 28, 2025 at 04:50:18AM -0800, Breno Leitao wrote:
> Convert the current state assignment to use explicit boolean conversion,
> making the code more robust and easier to read. This change adds a
> double-negation operator to ensure consistent boolean conversion as
> suggested by Paolo[1].
> 
> This approach aligns with the existing pattern used in
> sysdata_cpu_nr_enabled_show().
> 
> Link: https://lore.kernel.org/all/7309e760-63b0-4b58-ad33-2fb8db361141@xxxxxxxxxx/ [1]
> Signed-off-by: Breno Leitao <leitao@xxxxxxxxxx>

Thanks Breno,

FWIIW, I 100% agree with this change.

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux