On Tue, 31 Dec 2013 13:48:50 -0500 Joe Xue <lgxue@xxxxxxxxxxx> wrote: > >> + * Based on Richard Purdie's ledtrig-timer.c and Atsushi Nemoto's > >> + * ledtrig-heartbeat.c and Shuah Khan's ledtrig-transient.c > > > > I stil think this belongs in user space except for platforms with hardware > > acceleration for it. > > This can free the user space application from loop or thread. Which is not a good reason for putting it in the kernel. I could make the same argument for putting firefox in the kernel ... > > This doesn't as far as I can see do what you think. If I have the file > > currently open then device_remove_file will not remove my existing access > > to it, but you just released the pattern data so I now write to free > > memory. > > will add the mutex lock to avoid that Ok -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html