On Tue 2013-12-31 13:29:21, Richard Weinberger wrote: > On Tue, Dec 31, 2013 at 12:33 PM, Pavel Machek <pavel@xxxxxx> wrote: > > On Tue 2013-12-31 00:00:39, Joe Xue wrote: > >> > What about something like this? > >> > > >> > Not shcheduling timer when nothing changed should save a bit of power/cpu... > >> > > >> > if (pattern_data->pattern[pattern_data->count] == '/') { > >> > return; > >> > } > >> > > >> > this = pattern_data->pattern[pattern_data->count] > >> > if (this == '#') > >> > new_brigtness = pattern_data->brightness_on; > >> > if (this == ' ') > >> > new_brigtness = LED_OFF; > >> > repeat = 1; > >> > while (pattern_data->pattern[pattern_data->count + repeat] == this) > >> > repeat++; > >> > > >> > mod_timer(&pattern_data->timer, > >> > jiffies + msecs_to_jiffies(pattern_data->delay_unit * repeat)); > >> > > >> > > >> Working on it. > >> > >> Thanks for your help. > > > > You are welcome :-). > > Why do we need this within the kernel? > Patterns can easily created using a simple user space program. Some machines (N900) can do blinking in hardware, and we want consistent kernel-user interface. See the mailing list. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html