> From: Guenter Roeck <groeck7@xxxxxxxxx> On Behalf Of Guenter Roeck > Sent: Friday, February 21, 2025 10:34 AM > To: George Cherian <gcherian@xxxxxxxxxxx>; wim@xxxxxxxxxxxxxxxxxx; corbet@xxxxxxx > Cc: linux-watchdog@xxxxxxxxxxxxxxx; linux-doc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/2] drivers: watchdog: Add support for panic notifier callback > On 2/20/25 18:35, George Cherian wrote: >> Watchdog is not turned off in kernel panic situation. >> In certain systems this might prevent the successful loading >> of kdump kernel. The kdump kernel might hit a watchdog reset >> while it is booting. >> >> To avoid such scenarios add a panic notifier call back function >> which can stop the watchdog. This provision can be enabled on per >> driver basis if the user wishes to by setting the flag >> WDOG_STOP_ON_PANIC from respective drivers. >> > > I think this makes sense in principal, but it should not be driver specific. Thanks for the review. Will do the changes and post a v2. > >Guenter -George
