Re: [PATCH v2 2/3] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Aditya Garg <gargaditya08@xxxxxxxx>
Subject: Re: [PATCH v2 2/3] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc
From: "andriy.shevchenko@xxxxxxxxxxxxxxx" <andriy.shevchenko@xxxxxxxxxxxxxxx>
Date: Fri, 21 Feb 2025 22:23:19 +0200
Cc: "pmladek@xxxxxxxx" <pmladek@xxxxxxxx>, "rostedt@xxxxxxxxxxx" <rostedt@xxxxxxxxxxx>, "linux@xxxxxxxxxxxxxxxxxx" <linux@xxxxxxxxxxxxxxxxxx>, "senozhatsky@xxxxxxxxxxxx" <senozhatsky@xxxxxxxxxxxx>, "corbet@xxxxxxx" <corbet@xxxxxxx>, "maarten.lankhorst@xxxxxxxxxxxxxxx" <maarten.lankhorst@xxxxxxxxxxxxxxx>, "mripard@xxxxxxxxxx" <mripard@xxxxxxxxxx>, "tzimmermann@xxxxxxx" <tzimmermann@xxxxxxx>, "airlied@xxxxxxxxx" <airlied@xxxxxxxxx>, "simona@xxxxxxxx" <simona@xxxxxxxx>, "akpm@xxxxxxxxxxxxxxxxxxxx" <akpm@xxxxxxxxxxxxxxxxxxxx>, "apw@xxxxxxxxxxxxx" <apw@xxxxxxxxxxxxx>, "joe@xxxxxxxxxxx" <joe@xxxxxxxxxxx>, "dwaipayanray1@xxxxxxxxx" <dwaipayanray1@xxxxxxxxx>, "lukas.bulwahn@xxxxxxxxx" <lukas.bulwahn@xxxxxxxxx>, "sumit.semwal@xxxxxxxxxx" <sumit.semwal@xxxxxxxxxx>, "christian.koenig@xxxxxxx" <christian.koenig@xxxxxxx>, "kekrby@xxxxxxxxx" <kekrby@xxxxxxxxx>, "admin@xxxxxxxxxx" <admin@xxxxxxxxxx>, Orlando Chamberlain <orlandoch.dev@xxxxxxxxx>, "evepolonium@xxxxxxxxx" <evepolonium@xxxxxxxxx>, "linux-doc@xxxxxxxxxxxxxxx" <linux-doc@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "dri-devel@xxxxxxxxxxxxxxxxxxxxx" <dri-devel@xxxxxxxxxxxxxxxxxxxxx>, "linux-media@xxxxxxxxxxxxxxx" <linux-media@xxxxxxxxxxxxxxx>, "linaro-mm-sig@xxxxxxxxxxxxxxxx" <linaro-mm-sig@xxxxxxxxxxxxxxxx>, Hector Martin <marcan@xxxxxxxxx>, "linux@xxxxxxxxxxxxxxx" <linux@xxxxxxxxxxxxxxx>, "asahi@xxxxxxxxxxxxxxx" <asahi@xxxxxxxxxxxxxxx>, Sven Peter <sven@xxxxxxxxxxxxx>, Janne Grunau <j@xxxxxxxxxx>
In-reply-to: <PNZPR01MB4478C12B911E293C645E6EA6B8C72@PNZPR01MB4478.INDPRD01.PROD.OUTLOOK.COM>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <716BCB0A-785B-463A-86C2-94BD66D5D22E@live.com> <C66F35BB-2ECC-4DB8-8154-DEC5177967ED@live.com> <Z7ibRHb2FS1cTx0O@smile.fi.intel.com> <9C31901A-2C5C-478B-BB1C-D4705939EE4D@live.com> <PNZPR01MB4478C12B911E293C645E6EA6B8C72@PNZPR01MB4478.INDPRD01.PROD.OUTLOOK.COM>

On Fri, Feb 21, 2025 at 08:06:51PM +0000, Aditya Garg wrote:
> 
> > Does this look good now? Made orig a union.
> 
> Wait, it's messier. Maybe declare data type of val separately in each case?

Yes, this sounds better.

-- 
With Best Regards,
Andy Shevchenko

References:
- [PATCH v2 1/3] drm/format-helper: Add conversion from XRGB8888 to BGR888
  - From: Aditya Garg
- [PATCH v2 2/3] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc
  - From: Aditya Garg
- Re: [PATCH v2 2/3] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc
  - From: andriy.shevchenko@xxxxxxxxxxxxxxx
- Re: [PATCH v2 2/3] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc
  - From: Aditya Garg
- Re: [PATCH v2 2/3] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc
  - From: Aditya Garg

Prev by Date: Re: [PATCH v3 2/3] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc
Next by Date: Re: [PATCH 0/6] additional fixes to kernel-doc.py
Previous by thread: Re: [PATCH v2 2/3] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc
Next by thread: Re: [PATCH v2 2/3] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]