Hi all, I think Pavel's suggestion is a good idea, I'm starting to write another trigger named Morse code trigger. I prefer to keeping this burst trigger and add another Morse code trigger for different application. But I know the Morse code trigger will be the super set of the burst. Say the patten ... Morse code is same as the 3 times burst blinking. Anyway, after I finish that trigger, let community to decide which one will be adapted, or both. Any suggestion about the new Morse trigger, please let me know. Thank you Pavel. Joe ---------------------------------------- > From: lgxue@xxxxxxxxxxx > To: pavel@xxxxxx > CC: cooloney@xxxxxxxxx; rpurdie@xxxxxxxxx; rob@xxxxxxxxxxx; milo.kim@xxxxxx; linux-leds@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-doc@xxxxxxxxxxxxxxx > Subject: RE: [PATCH] Add the LED burst trigger > Date: Thu, 26 Dec 2013 10:02:38 -0500 > > Hi Pavel, > > Yes, your suggest looks reasonable. Only issue maybe is not easy to called by program. After all, the interface is called by program more ofter then by human being. > > I would like to change the way what you suggest, let see if other guys agree with your idea. > > Before that, I'll submit another change as per Geert's suggest that change HZ to Hz. > > Joe > > ---------------------------------------- >> Date: Thu, 26 Dec 2013 15:26:08 +0100 >> From: pavel@xxxxxx >> To: lgxue@xxxxxxxxxxx >> CC: cooloney@xxxxxxxxx; rpurdie@xxxxxxxxx; rob@xxxxxxxxxxx; milo.kim@xxxxxx; linux-leds@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-doc@xxxxxxxxxxxxxxx >> Subject: Re: [PATCH] Add the LED burst trigger >> >> Hi! >> >>> Yes, Morse code can indicate any means. But when we look at the LEDs, would we like to also have a Morse code book in hand? >>> >>> The burst led blink idea is because it is easy to use and easy to describe. Mostly when users on site are describing the LEDs states to the support engineer. >>> >> >> Well.. above 7 or so blinks, people will be unable to count. "one >> short, one long" will help to extend that. >> >> Plus, there may be patterns such as "keep it ON, count number of brief >> OFFs"... >> >> That's why I suggested: >> >>>> echo 40> step_length_ms >>>> echo "- - - "> pattern >>>> >>>> do the same trick? >>>> >>>> Plus, you could for example do >>>> >>>> echo "- --- "> pattern >>>> >>>> to do morse code... >> >> Interface >> >> (Note that your client stripped some spaces out of it). >> >> With that, it should be very easy to program all the reasonable >> blinking patterns for single LED without PWM. >> Pavel >> -- >> (english) http://www.livejournal.com/~pavelmachek >> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html