On Fri, Feb 21, 2025 at 11:37:13AM +0000, Aditya Garg wrote: > From: Hector Martin <marcan@xxxxxxxxx> First of all, I do not see the cover letter. Is it only an issue on my side? > %p4cc is designed for DRM/V4L2 FOURCCs with their specific quirks, but > it's useful to be able to print generic 4-character codes formatted as > an integer. Extend it to add format specifiers for printing generic > 32-bit FOURCCs with various endian semantics: > > %p4ch Host-endian > %p4cl Little-endian > %p4cb Big-endian > %p4cr Reverse-endian > > The endianness determines how bytes are interpreted as a u32, and the > FOURCC is then always printed MSByte-first (this is the opposite of > V4L/DRM FOURCCs). This covers most practical cases, e.g. %p4cr would > allow printing LSByte-first FOURCCs stored in host endian order > (other than the hex form being in character order, not the integer > value). Second, don't issue versions too fast, give at least a few days for the reviewers to have a chance on looking into it. Due to above this inherits the same issues as v2, please refer to my comments there. -- With Best Regards, Andy Shevchenko
