On Wed, 19 Feb 2025 10:11:01 -0700 Daniel Xu wrote: > > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c > > index f88b641533fc..1bfff7f29310 100644 > > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c > > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c > > @@ -395,6 +395,10 @@ static int bnxt_xdp_set(struct bnxt *bp, struct bpf_prog *prog) > > bp->dev->mtu, BNXT_MAX_PAGE_MODE_MTU); > > return -EOPNOTSUPP; > > } > > + if (prog && bp->flags & BNXT_FLAG_HDS) { > > + netdev_warn(dev, "XDP is disallowed when HDS is enabled.\n"); > > + return -EOPNOTSUPP; > > + } > > I think there might be a bug here. On my 6.13 (ish) kernel when I try to > install an XDP driver mode program, I get: > > [Tue Feb 18 17:02:14 2025] bnxt_en 0000:01:00.0 eth0: XDP is disallowed when HDS is enabled. > > Setting HDS to auto (seems like off isn't supported?) doesn't seem to > help either: This should fix it, I think: https://lore.kernel.org/20250220005318.560733-1-kuba@xxxxxxxxxx