Re: [PATCH v2 1/3] clocksource: timer-keystone: introduce clocksource driver for Keystone

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/24/2013 02:58 AM, Stephen Boyd wrote:
On 12/17, Ivan Khoronzhuk wrote:
+static void __init keystone_timer_init(struct device_node *np)
+{
+	struct clock_event_device *event_dev = &timer.event_dev;
+	unsigned long rate;
[...]
+
+	timer.hz_period = rate / (HZ);

Unnecessary parentheses here. Also, do you need to use do_div()
here? I'm lost how the hz_period is ever greater than 32 bits
though because HZ is most likely very small and the rate is
unsigned long.


You are right.
I'll do the following:

timer.hz_period = rate / (HZ)	---> timer.hz_period = rate / HZ
u64 hz_period			---> unsigned long hz_period

--
Regards,
Ivan Khoronzhuk
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux