On Fri, Jan 24, 2025 at 04:30:41PM -0800, Nicolin Chen wrote: > + int ret; > struct arm_smmu_ste ste; > struct arm_smmu_master *master = dev_iommu_priv_get(dev); > + struct arm_smmu_attach_state state = { > + .master = master, > + }; > + > + ret = arm_smmu_attach_prepare_vmaster(&state, domain); > + if (ret) > + return ret; > + arm_smmu_attach_commit_vmaster(&state); I think you should make this into just a arm_smmu_clear_vmaster() with less complication.. Jason