Re: [PATCH RESEND v2 3/3] x86/cpu: Enable modifying bug flags with {clear,set}puid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Borislav Petkov <bp@xxxxxxxxx>
Subject: Re: [PATCH RESEND v2 3/3] x86/cpu: Enable modifying bug flags with {clear,set}puid
From: Brendan Jackman <jackmanb@xxxxxxxxxx>
Date: Mon, 17 Feb 2025 12:20:56 +0100
Cc: Jonathan Corbet <corbet@xxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, x86@xxxxxxxxxx, "H. Peter Anvin" <hpa@xxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, linux-doc@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20250217111029.GIZ7MZJUGJRoeiScgn@fat_crate.local>
References: <20250129-force-cpu-bug-v2-0-5637b337b443@google.com> <20250129-force-cpu-bug-v2-3-5637b337b443@google.com> <20250217111029.GIZ7MZJUGJRoeiScgn@fat_crate.local>

On Mon, 17 Feb 2025 at 12:10, Borislav Petkov <bp@xxxxxxxxx> wrote:
>
> >  extern const char * const x86_bug_flags[NBUGINTS*32];
> > +#define x86_bug_flag(flag) x86_bug_flags[flag]
>
> Why?

That's just for consistency with x86_cap_flag().

I don't remember seeing any reason why that indirection exists. Maybe
it's vestigial. Shall I just remove it?

To everything else: ack, thanks for the review.

Follow-Ups:
- Re: [PATCH RESEND v2 3/3] x86/cpu: Enable modifying bug flags with {clear,set}puid
  - From: Borislav Petkov

References:
- [PATCH RESEND v2 0/3] x86/cpu: Add facility to force-enable CPU caps and bugs
  - From: Brendan Jackman
- [PATCH RESEND v2 3/3] x86/cpu: Enable modifying bug flags with {clear,set}puid
  - From: Brendan Jackman
- Re: [PATCH RESEND v2 3/3] x86/cpu: Enable modifying bug flags with {clear,set}puid
  - From: Borislav Petkov

Prev by Date: [PATCH] docs: tracing: Reduce maxdepth in index documentation
Next by Date: [PATCH v3] docs: kconfig: Mention IS_REACHABLE as way for optional dependency
Previous by thread: Re: [PATCH RESEND v2 3/3] x86/cpu: Enable modifying bug flags with {clear,set}puid
Next by thread: Re: [PATCH RESEND v2 3/3] x86/cpu: Enable modifying bug flags with {clear,set}puid
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]